LGTM
On Apr 30, 2011 11:34 PM, <adg@golang.org> wrote:
> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> http: rename ErrBodyReadAferClose to ErrBodyReadAfterClose
>
> Please review this at http://codereview.appspot.com/4432085/
>
> Affected files:
> M src/pkg/http/transfer.go
>
>
> Index: src/pkg/http/transfer.go
> ===================================================================
> --- a/src/pkg/http/transfer.go
> +++ b/src/pkg/http/transfer.go
> @@ -442,15 +442,15 @@
> closed bool
> }
>
> -// ErrBodyReadAferClose is returned when reading a Request Body after
> +// ErrBodyReadAfterClose is returned when reading a Request Body after
> // the body has been closed. This typically happens when the body is
> // read after an HTTP Handler calls WriteHeader or Write on its
> // ResponseWriter.
> -var ErrBodyReadAferClose = os.NewError("http: invalid Read on closed
> request Body")
> +var ErrBodyReadAfterClose = os.NewError("http: invalid Read on closed
> request Body")
>
> func (b *body) Read(p []byte) (n int, err os.Error) {
> if b.closed {
> - return 0, ErrBodyReadAferClose
> + return 0, ErrBodyReadAfterClose
> }
> return b.Reader.Read(p)
> }
>
>
Issue 4432085: code review 4432085: http: rename ErrBodyReadAferClose to ErrBodyReadAfterClose
(Closed)
Created 14 years ago by adg
Modified 14 years ago
Reviewers:
Base URL:
Comments: 0