Issue 4431074: code review 4431074: syslog: Fix skipping of net tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4431074: code review 4431074: syslog: Fix skipping of net tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by niemeyer

Modified:
14 years ago

Reviewers:

CC:
golang-dev, rsc1

Visibility:
Public.

Description

syslog: fix skipping of net tests Also remove some left over copy & paste in the test of reflect.Copy for arrays.

Patch Set 1 #

Patch Set 2 : code review 4431074: syslog: Fix skipping of net tests #

Patch Set 3 : diff -r 4abcd1a58d3d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4abcd1a58d3d https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 4abcd1a58d3d https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r bdb77920419f https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -10 lines)			Patch
	M	src/pkg/reflect/all_test.go	View	1 2 3 4	1 chunk	+1 line, -7 lines	0 comments	Download
	M	src/pkg/syslog/syslog_test.go	View	1 2	3 chunks	+17 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-04-28 16:55:34 UTC) #1

rsc1

LGTM might as well unwrap the Errorf line now. s/Fix/fix/ in the CL description

14 years ago (2011-04-28 17:05:53 UTC) #2

niemeyer

14 years ago (2011-04-28 17:16:46 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=0c3a18c3bca1 ***

syslog: fix skipping of net tests

Also remove some left over copy & paste
in the test of reflect.Copy for arrays.

R=golang-dev, rsc1
CC=golang-dev
http://codereview.appspot.com/4431074

Expand All Messages | Collapse All Messages