Issue 4430069: Only warn once for each invalid typedefs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4430069: Only warn once for each invalid typedefs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 12 months ago by rtrieu

Modified:
12 years, 10 months ago

Reviewers:
chandlerc

Base URL:
https://llvm.org/svn/llvm-project/cfe/trunk/

Visibility:
Public.

Description

Submitted at revision 131043

Patch Set 1 #

Patch Set 2 : Revert error message back to original format. #

Patch Set 3 : Fix a comment. #

Total comments: 1

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -3 lines)			Patch
	M	lib/Sema/TreeTransform.h	View	1 2	1 chunk	+7 lines, -3 lines	1 comment	Download
	M	test/SemaTemplate/typename-specifier.cpp	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

chandlerc

12 years, 11 months ago (2011-05-26 10:35:03 UTC) #1

http://codereview.appspot.com/4430069/diff/3001/lib/Sema/TreeTransform.h
File lib/Sema/TreeTransform.h (right):

http://codereview.appspot.com/4430069/diff/3001/lib/Sema/TreeTransform.h#newc...
lib/Sema/TreeTransform.h:2533: // If the nested-name-specifier is an invalid
type def, don't emit an
What about an invalid class decl? This seems unnecessarily special cased... I'd
love to see something more general here.

Expand All Messages | Collapse All Messages