code review 4425063: go/types: type checker API + testing infrastructure

go/types: type checker API + testing infrastructure

At the moment types.Check() only deals with global
types and only partially so. But the framework is
there to compute them and check for cycles. An initial
type test is passing.

First step of a series of CLs to come.

[gri, 2011-04-28 21:06:36]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2011-05-13 01:34:34]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-05-13 22:09:11]

LGTM

Was smaller than I expected.  Sorry for putting it off during the I/O ramp-up.

http://codereview.appspot.com/4425063/diff/30011/src/pkg/go/types/check.go
File src/pkg/go/types/check.go (right):

http://codereview.appspot.com/4425063/diff/30011/src/pkg/go/types/check.go#ne...
src/pkg/go/types/check.go:22: type checker struct {
Great line.

http://codereview.appspot.com/4425063/diff/30011/src/pkg/go/types/check.go#ne...
src/pkg/go/types/check.go:36: func (c *checker) collectFields(tok token.Token,
list *ast.FieldList, cycleOk bool) (fields ObjList, tags []string, isVariadic
bool) {
// comment here.  
mention that this is used for struct fields, interface method lists, and
function arguments

http://codereview.appspot.com/4425063/diff/30011/src/pkg/go/types/check_test.go
File src/pkg/go/types/check_test.go (right):

http://codereview.appspot.com/4425063/diff/30011/src/pkg/go/types/check_test....
src/pkg/go/types/check_test.go:126: return errors
doesn't this stop on the first file in the list?

http://codereview.appspot.com/4425063/diff/30011/src/pkg/go/types/gcimporter.go
File src/pkg/go/types/gcimporter.go (right):

http://codereview.appspot.com/4425063/diff/30011/src/pkg/go/types/gcimporter....
src/pkg/go/types/gcimporter.go:373: parseField := func() {
nice

http://codereview.appspot.com/4425063/diff/30011/src/pkg/go/types/types.go
File src/pkg/go/types/types.go (right):

http://codereview.appspot.com/4425063/diff/30011/src/pkg/go/types/types.go#ne...
src/pkg/go/types/types.go:182: // (to avoid spurios follow-up errors).
s/spurios/spurious/

[gri, 2011-05-13 22:22:34]

http://codereview.appspot.com/4425063/diff/30011/src/pkg/go/types/check.go
File src/pkg/go/types/check.go (right):

http://codereview.appspot.com/4425063/diff/30011/src/pkg/go/types/check.go#ne...
src/pkg/go/types/check.go:22: type checker struct {
On 2011/05/13 22:09:12, rsc wrote:
> Great line.

Done.

http://codereview.appspot.com/4425063/diff/30011/src/pkg/go/types/check.go#ne...
src/pkg/go/types/check.go:36: func (c *checker) collectFields(tok token.Token,
list *ast.FieldList, cycleOk bool) (fields ObjList, tags []string, isVariadic
bool) {
On 2011/05/13 22:09:12, rsc wrote:
> // comment here.  
> mention that this is used for struct fields, interface method lists, and
> function arguments

Done.

http://codereview.appspot.com/4425063/diff/30011/src/pkg/go/types/check_test.go
File src/pkg/go/types/check_test.go (right):

http://codereview.appspot.com/4425063/diff/30011/src/pkg/go/types/check_test....
src/pkg/go/types/check_test.go:126: return errors
On 2011/05/13 22:09:12, rsc wrote:
> doesn't this stop on the first file in the list?

good point! (not noticeable with single file tests).
fixed.

http://codereview.appspot.com/4425063/diff/30011/src/pkg/go/types/gcimporter.go
File src/pkg/go/types/gcimporter.go (right):

http://codereview.appspot.com/4425063/diff/30011/src/pkg/go/types/gcimporter....
src/pkg/go/types/gcimporter.go:373: parseField := func() {
On 2011/05/13 22:09:12, rsc wrote:
> nice

Done.

http://codereview.appspot.com/4425063/diff/30011/src/pkg/go/types/types.go
File src/pkg/go/types/types.go (right):

http://codereview.appspot.com/4425063/diff/30011/src/pkg/go/types/types.go#ne...
src/pkg/go/types/types.go:182: // (to avoid spurios follow-up errors).
On 2011/05/13 22:09:12, rsc wrote:
> s/spurios/spurious/

Done.

[gri, 2011-05-13 22:31:13]

*** Submitted as http://code.google.com/p/go/source/detail?r=8c1eff180ecc ***

go/types: type checker API + testing infrastructure

At the moment types.Check() only deals with global
types and only partially so. But the framework is
there to compute them and check for cycles. An initial
type test is passing.

First step of a series of CLs to come.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4425063