Issue 4418041: Make implicit assumptions in GTMWindowSheetController explicit by adding asserts.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4418041: Make implicit assumptions in GTMWindowSheetController explicit by adding asserts. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by thakis

Modified:
13 years ago

Reviewers:
Avi D

Base URL:
http://google-toolbox-for-mac.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Make implicit assumptions in GTMWindowSheetController explicit by adding asserts. Committed: http://code.google.com/p/google-toolbox-for-mac/source/detail?r=440

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments, remove if #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	GTMWindowSheetController.h	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
	M	GTMWindowSheetController.m	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Avi D

My my, this is paranoid. LGTM. You're aware you'll have to check this into the ...

13 years ago (2011-04-14 03:24:34 UTC) #2

thakis

13 years ago (2011-04-14 19:00:26 UTC) #3

I was thinking about how to write a test that proves that the if() I added was
necessary and discovered that it's in fact not necessary. So I removed it. Will
send this through p4 in a minute.

http://codereview.appspot.com/4418041/diff/1/AppKit/GTMWindowSheetController.h
File AppKit/GTMWindowSheetController.h (right):

http://codereview.appspot.com/4418041/diff/1/AppKit/GTMWindowSheetController....
AppKit/GTMWindowSheetController.h:78: //                contextInfo:]. You must
only call this method if the
On 2011/04/14 03:24:35, Avi D wrote:
> Oh this wrapping is wack. If you start the new line with beginSheet:, can you
> fit the entire selector on one line? Play with this a little.

Done.

Expand All Messages | Collapse All Messages