Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(216)

Issue 4416044: code review 4416044: gobuilder: permit builders of the form goos-goarch-foo (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 6 months ago by adg
Modified:
14 years, 6 months ago
Reviewers:
bradfitzgoog, rsc1
CC:
dave_cheney.net, golang-dev
Visibility:
Public.

Description

gobuilder: permit builders of the form goos-goarch-foo

Patch Set 1 #

Patch Set 2 : diff -r 97815e81c184 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M misc/dashboard/builder/main.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
adg
Hello dfc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 6 months ago (2011-04-15 01:45:12 UTC) #1
dave_cheney.net
Yup, that fixed the problem.
14 years, 6 months ago (2011-04-15 01:47:35 UTC) #2
adg
*** Submitted as http://code.google.com/p/go/source/detail?r=af52fabbb535 *** gobuilder: permit builders of the form goos-goarch-foo R=dfc CC=golang-dev http://codereview.appspot.com/4416044
14 years, 6 months ago (2011-04-15 01:57:04 UTC) #3
rsc1
i wonder why linux-arm-qemu was already working
14 years, 6 months ago (2011-04-15 03:57:35 UTC) #4
bradfitzgoog
14 years, 6 months ago (2011-04-15 03:59:16 UTC) #5
well, it hasn't been working too well... ;)

(phone), brad
On Apr 14, 2011 8:57 PM, "Russ Cox" <rsc@google.com> wrote:
> i wonder why linux-arm-qemu was already working
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b