code review 4399044: http: flesh out server Expect handling + tests

http: flesh out server Expect handling + tests

This mostly adds Expect 100-continue tests (from
the perspective of server correctness) that were
missing before.

It also fixes a few missing cases that will
probably never come up in practice, but it's nice
to have handled correctly.

Proper 100-continue client support remains a TODO.

[bradfitz, 2011-04-13 20:32:05]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-04-13 20:38:51]

LGTM after fixes

http://codereview.appspot.com/4399044/diff/5001/src/pkg/http/serve_test.go
File src/pkg/http/serve_test.go (right):

http://codereview.appspot.com/4399044/diff/5001/src/pkg/http/serve_test.go#ne...
src/pkg/http/serve_test.go:594: tests := []serverExpectTest{
typically these are at top level ...

var serverExpectTests = []struct{
  contentLength    int    // of request body
  ...
}{
    {100, ...},
    ...
}

http://codereview.appspot.com/4399044/diff/5001/src/pkg/http/serve_test.go#ne...
src/pkg/http/serve_test.go:616: runTest(test)
... and this just has the body of runTest right here
instead of defining a separate function

[bradfitzgoog, 2011-04-13 20:45:19]

http://codereview.appspot.com/4399044/diff/5001/src/pkg/http/serve_test.go
File src/pkg/http/serve_test.go (right):

http://codereview.appspot.com/4399044/diff/5001/src/pkg/http/serve_test.go#ne...
src/pkg/http/serve_test.go:616: runTest(test)
On 2011/04/13 20:38:51, rsc wrote:
> ... and this just has the body of runTest right here
> instead of defining a separate function

But I want to use defer.  :)

And we don't have block-level defer, only func-level.

[rsc, 2011-04-13 20:52:47]

> But I want to use defer.  :)

Ha.  I looked and missed it.
Probably still good to put the tests at top level
but otherwise LGTM.

[bradfitz, 2011-04-13 21:09:06]

*** Submitted as http://code.google.com/p/go/source/detail?r=5460672121a9 ***

http: flesh out server Expect handling + tests

This mostly adds Expect 100-continue tests (from
the perspective of server correctness) that were
missing before.

It also fixes a few missing cases that will
probably never come up in practice, but it's nice
to have handled correctly.

Proper 100-continue client support remains a TODO.

R=rsc, bradfitzwork
CC=golang-dev
http://codereview.appspot.com/4399044