Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1351)

Issue 4388041: Doc: Added @knownissue to Grace Notes for MIDI (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by pkx166h
Modified:
13 years ago
Reviewers:
carl.d.sorensen, Trevor Daniels, Graham Percival (old account)
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: Added @knownissue to Grace Notes for MIDI As per thread http://article.gmane.org/gmane.comp.gnu.lilypond.general/63450 When using MIDI with grace notes some manual tweaking made be required to get the 'correct' length of the grace note to be played.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Second Draft. #

Total comments: 5

Patch Set 3 : Third Draft #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M Documentation/notation/rhythms.itely View 1 2 2 chunks +30 lines, -6 lines 0 comments Download

Messages

Total messages: 9
Carl
Looks generally good, but I think we need to include the error message text in ...
13 years ago (2011-04-07 17:48:37 UTC) #1
Trevor Daniels
Suggested rewording, accommodating Carl's suggestion. Otherwise, looks fine. Trevor http://codereview.appspot.com/4388041/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/4388041/diff/1/Documentation/notation/rhythms.itely#newcode3239 Documentation/notation/rhythms.itely:3239: ...
13 years ago (2011-04-07 22:31:25 UTC) #2
pkx166h
On 2011/04/07 22:31:25, Trevor Daniels wrote: > Suggested rewording, accommodating Carl's suggestion. > > Otherwise, ...
13 years ago (2011-04-08 16:45:56 UTC) #3
Trevor Daniels
Nearly there :) http://codereview.appspot.com/4388041/diff/4001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/4388041/diff/4001/Documentation/notation/rhythms.itely#newcode3240 Documentation/notation/rhythms.itely:3240: length of the preceding note a ...
13 years ago (2011-04-08 23:25:32 UTC) #4
Graham Percival (old account)
http://codereview.appspot.com/4388041/diff/4001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/4388041/diff/4001/Documentation/notation/rhythms.itely#newcode3240 Documentation/notation/rhythms.itely:3240: length of the preceding note a @emph{"Going back in ...
13 years ago (2011-04-08 23:29:07 UTC) #5
pkx166h
Third Draft. Regards http://codereview.appspot.com/4388041/diff/4001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/4388041/diff/4001/Documentation/notation/rhythms.itely#newcode3240 Documentation/notation/rhythms.itely:3240: length of the preceding note a ...
13 years ago (2011-04-09 16:19:42 UTC) #6
Trevor Daniels
LGTM Trevor
13 years ago (2011-04-09 17:43:44 UTC) #7
Graham Percival (old account)
LGTM
13 years ago (2011-04-09 23:39:44 UTC) #8
pkx166h
13 years ago (2011-04-10 13:12:40 UTC) #9
Pushed as commit	53390e0570f4544c131e77323cdc4f4ea738bddd
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b