Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(37)

Issue 4387041: code review 4387041: codereview: drop Author: line on self-clpatch (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by rsc
Modified:
14 years, 1 month ago
Reviewers:
CC:
golang-dev, r2
Visibility:
Public.

Description

codereview: drop Author: line on self-clpatch Right now if a Go developer makes a patch on one machine and then clpatches it onto another machine, changes subsequently made to the description are kept only locally, under the assumption that you are running clpatch because someone else wrote the CL, so you don't have permission to update the web. This change makes clpatch discard the "this was a clpatch" information from the metadata when you clpatch your own CLs from one machine to another. This should eliminate some confusion (for example in CL 4314054) but will no doubt introduce other confusion.

Patch Set 1 #

Patch Set 2 : diff -r f618e5e0991d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f618e5e0991d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f618e5e0991d https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M lib/codereview/codereview.py View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 1 month ago (2011-04-07 13:22:53 UTC) #1
r2
LGTM
14 years, 1 month ago (2011-04-07 15:07:11 UTC) #2
rsc
14 years, 1 month ago (2011-04-07 17:03:11 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=2bb9f35da1f3 ***

codereview: drop Author: line on self-clpatch

Right now if a Go developer makes a patch on one machine
and then clpatches it onto another machine, changes
subsequently made to the description are kept only
locally, under the assumption that you are running
clpatch because someone else wrote the CL, so you
don't have permission to update the web.

This change makes clpatch discard the "this was a
clpatch" information from the metadata when you
clpatch your own CLs from one machine to another.

This should eliminate some confusion (for example
in CL 4314054) but will no doubt introduce other
confusion.

R=golang-dev, r2
CC=golang-dev
http://codereview.appspot.com/4387041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b