Issue 4386048: code review 4386048: freetype: update for os.Open changes.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4386048: code review 4386048: freetype: update for os.Open changes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by nigeltao

Modified:
13 years, 7 months ago

Reviewers:
nigeltao_gnome

CC:
adg, r2, golang-dev

Visibility:
Public.

Description

freetype: update for os.Open changes.

Patch Set 1 #

Patch Set 2 : diff -r 54ae189db3dd https://freetype-go.googlecode.com/hg/ #

Patch Set 3 : diff -r 54ae189db3dd https://freetype-go.googlecode.com/hg/ #

Patch Set 4 : diff -r 54ae189db3dd https://freetype-go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	example/freetype/main.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	example/gamma/main.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	example/raster/main.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	example/round/main.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

nigeltao

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://freetype-go.googlecode.com/hg/

13 years, 7 months ago (2011-04-11 00:08:47 UTC) #1

nigeltao

*** Submitted as http://code.google.com/p/freetype-go/source/detail?r=0a1082ff91e2 *** freetype: update for os.Open changes. R=adg, r2 CC=golang-dev http://codereview.appspot.com/4386048

13 years, 7 months ago (2011-04-11 00:48:20 UTC) #4

nigeltao_gnome

13 years, 7 months ago (2011-04-11 00:48:32 UTC) #5

On 11 April 2011 10:14, Rob 'Commander' Pike <r@google.com> wrote:
> but why were they 0600?

No particular reason.

Expand All Messages | Collapse All Messages