Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(628)

Issue 4385053: Allows users to prevent rests from automatically shifting. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by MikeSol
Modified:
12 years, 8 months ago
Reviewers:
Graham Percival, mike, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Allows users to prevent rests from automatically shifting.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Carl's proposed changes and a regtest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
A input/regression/multi-measure-rest-automatic-shift.ly View 1 1 chunk +15 lines, -0 lines 0 comments Download
M lily/multi-measure-rest.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M scm/define-grob-properties.scm View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7
MikeSol
Potential fix for issue 1604.
12 years, 11 months ago (2011-04-10 11:12:52 UTC) #1
Carl
Wow -- what a quick response! Thanks! I have a couple of comments. Carl http://codereview.appspot.com/4385053/diff/1/scm/define-grob-properties.scm ...
12 years, 11 months ago (2011-04-10 12:49:46 UTC) #2
MikeSol
New patch set uploaded w/ a regtest. Before I push, could someone please run the ...
12 years, 11 months ago (2011-04-10 19:41:51 UTC) #3
Graham Percival
On Sun, Apr 10, 2011 at 07:41:51PM +0000, mtsolo@gmail.com wrote: > New patch set uploaded ...
12 years, 11 months ago (2011-04-11 01:35:20 UTC) #4
Carl
Instead of adding a property, is there a way to just make the default value ...
12 years, 11 months ago (2011-04-11 01:56:18 UTC) #5
Carl
Instead of adding a property, is there a way to just make the default value ...
12 years, 11 months ago (2011-04-11 01:56:20 UTC) #6
mike_apollinemike.com
12 years, 11 months ago (2011-04-11 08:58:23 UTC) #7
On Apr 10, 2011, at 9:56 PM, Carl.D.Sorensen@gmail.com wrote:

> Instead of adding a property, is there a way to just make the default
> value of the property be staff_space?
> 
> Thanks,
> 
> Carl
> 
> 
> http://codereview.appspot.com/4385053/

The issue with this is that it'd kick all church rests up by staff_space.

Cheers,
MS
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b