Allows users to prevent rests from automatically shifting.

Allows users to prevent rests from automatically shifting.

[MikeSol, 2011-04-10 11:12:52]

Potential fix for issue 1604.

[Carl, 2011-04-10 12:49:46]

Wow -- what a quick response!  Thanks!

I have a couple of comments.

Carl

http://codereview.appspot.com/4385053/diff/1/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/4385053/diff/1/scm/define-grob-properties.scm#n...
scm/define-grob-properties.scm:61: (automatic-shift ,boolean? "Should a rest be
automatically shifted?")
Since this applies to both MMRest and Percent Repeat, should it say "rest"?

Also, I think it should have a statement that defines the kind of shift we're
talking about, if possible.

http://codereview.appspot.com/4385053/diff/1/scm/define-grobs.scm
File scm/define-grobs.scm (right):

http://codereview.appspot.com/4385053/diff/1/scm/define-grobs.scm#newcode1545
scm/define-grobs.scm:1545: (automatic-shift . #t)
You've added this property to the PercentRepeat grob, but I don't see where the
engraver has been changed.

[MikeSol, 2011-04-10 19:41:51]

New patch set uploaded w/ a regtest.

Before I push, could someone please run the regtests on this patch?  I got an
anomaly in partcombine-midi.ly, but I don't know if that's because I messed up
the regest or if in fact my code is buggy.  I'm tending to think the former, as
when I compile this file manually it looks fine.

Cheers,
MIke

[Graham Percival, 2011-04-11 01:35:20]

On Sun, Apr 10, 2011 at 07:41:51PM +0000, mtsolo@gmail.com wrote:
> New patch set uploaded w/ a regtest.

Thanks added as
http://code.google.com/p/lilypond/issues/detail?id=1608

> Before I push, could someone please run the regtests on this patch?

I haven't checked it yet, but at least it's in the system.

Cheers,
- Graham

[Carl, 2011-04-11 01:56:18]

Instead of adding a property, is there a way to just make the default value of
the property be staff_space?

Thanks,

Carl

[Carl, 2011-04-11 01:56:20]

Instead of adding a property, is there a way to just make the default value of
the property be staff_space?

Thanks,

Carl

[mike_apollinemike.com, 2011-04-11 08:58:23]

On Apr 10, 2011, at 9:56 PM, Carl.D.Sorensen@gmail.com wrote:

> Instead of adding a property, is there a way to just make the default
> value of the property be staff_space?
> 
> Thanks,
> 
> Carl
> 
> 
> http://codereview.appspot.com/4385053/

The issue with this is that it'd kick all church rests up by staff_space.

Cheers,
MS