Issue 4385047: Modifies quote.ly and quote-during.ly to revert to their original behavior.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4385047: Modifies quote.ly and quote-during.ly to revert to their original behavior. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by MikeSol

Modified:
13 years ago

Reviewers:
Graham Percival (old account)

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Modifies quote.ly and quote-during.ly to revert to their original behavior. Beam collision avoidance now causes stems to elongate to avoid collisions. To reinstate the collisions, the collision-voice-only property has been set to ##t.

Patch Set 1 #

Total comments: 2

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	input/regression/quote.ly	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	input/regression/quote-during.ly	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Graham Percival (old account)

13 years ago (2011-04-09 01:47:12 UTC) #2

not tested, but go ahead and push.  I think that for stuff this simple, you can
skip the rietveld step.

http://codereview.appspot.com/4385047/diff/1/input/regression/quote-during.ly
File input/regression/quote-during.ly (right):

http://codereview.appspot.com/4385047/diff/1/input/regression/quote-during.ly...
input/regression/quote-during.ly:35: \new Voice { \override Voice . Beam
#'collision-voice-only = ##t \original }
I'd rather have some line-breaks in here.
  \new Voice {
    \override
    \original
  }

http://codereview.appspot.com/4385047/diff/1/input/regression/quote.ly
File input/regression/quote.ly (right):

http://codereview.appspot.com/4385047/diff/1/input/regression/quote.ly#newcode33
input/regression/quote.ly:33: \new Voice { \override Voice . Beam
#'collision-voice-only = ##t \original }
ditto

Expand All Messages | Collapse All Messages