code review 4385042: codereview: recognize code URL without trailing slash

codereview: recognize code URL without trailing slash

[rsc, 2011-04-07 02:46:51]

Hello adg (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2011-04-07 02:50:47]

LGTM

On 7 April 2011 12:46,  <rsc@golang.org> wrote:
> Reviewers: adg,
>
> Message:
> Hello adg (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> codereview: recognize code URL without trailing slash
>
> Please review this at http://codereview.appspot.com/4385042/
>
> Affected files:
>  M lib/codereview/codereview.py
>
>
> Index: lib/codereview/codereview.py
> ===================================================================
> --- a/lib/codereview/codereview.py
> +++ b/lib/codereview/codereview.py
> @@ -1463,7 +1463,7 @@
>        # we're committed. upload final patch, close review, add commit
> message
>        changeURL = short(node)
>        url = other.url()
> -       m = re.match("^https?://([^@/]+@)?([^.]+)\.googlecode\.com/hg/",
> url)
> +       m = re.match("^https?://([^@/]+@)?([^.]+)\.googlecode\.com/hg/?",
> url)
>        if m:
>                changeURL = "http://code.google.com/p/%s/source/detail?r=%s"
> % (m.group(2), changeURL)
>        else:
>
>
>

[rsc, 2011-04-07 03:07:11]

*** Submitted as http://code.google.com/p/go/source/detail?r=6336d9281325 ***

codereview: recognize code URL without trailing slash

R=adg
CC=golang-dev
http://codereview.appspot.com/4385042