Adds footnote-footer-padding to the paper bloc.

Adds footnote-footer-padding to the paper bloc.

[MikeSol, 2011-04-08 02:14:44]

Fixes the problem flagged by Reinhold regarding the spacing between the footer
and the footnotes by adding footnote-footer-padding to the paper bloc.

[Graham Percival (old account), 2011-04-08 03:32:24]

umm.  Getting into Canadian politics?

added here:
http://code.google.com/p/lilypond/issues/detail?id=1599

[Graham Percival (old account), 2011-04-08 07:35:06]

This patch appears to break partcombine-midi.ly, but since that's a very new
part of the regtests, I'm not totally confident that this isn't just a random
fluctuation in midi2ly.

Do you see the same behaviour when running a regtest comparison?  This is the
first regtest comparison I've done since we added the midi stuff, so I could
believe that it's a coincidence.

[Graham Percival (old account), 2011-04-08 07:44:17]

On 2011/04/08 07:35:06, Graham Percival wrote:
> This patch appears to break partcombine-midi.ly, but since that's a very new
> part of the regtests, I'm not totally confident that this isn't just a random
> fluctuation in midi2ly.

Never mind; I removed your patch, built a new regtest comparison, and I see the
same mistake in partcomine-midi.ly.  It definitely has nothing to do with your
patch.

[mike_apollinemike.com, 2011-04-08 15:02:35]

On Apr 8, 2011, at 3:44 AM, percival.music.ca@gmail.com wrote:

> On 2011/04/08 07:35:06, Graham Percival wrote:
>> This patch appears to break partcombine-midi.ly, but since that's a
> very new
>> part of the regtests, I'm not totally confident that this isn't just a
> random
>> fluctuation in midi2ly.
> 
> Never mind; I removed your patch, built a new regtest comparison, and I
> see the same mistake in partcomine-midi.ly.  It definitely has nothing
> to do with your patch.
> 
> http://codereview.appspot.com/4384046/
> 
> _______________________________________________
> lilypond-devel mailing list
> lilypond-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/lilypond-devel

I get a clean regtest too, although there was a bug in page-spacing.cc that I
just fixed with a new patch set (the bug didn't show itself because of the
default values I chose).
Fixed and new patch set uploaded.

Cheers,
MS

[Neil Puttock, 2011-04-08 21:27:11]

LGTM, just needs a regtest.

http://codereview.appspot.com/4384046/diff/5001/lily/page-spacing.cc
File lily/page-spacing.cc (right):

http://codereview.appspot.com/4384046/diff/5001/lily/page-spacing.cc#newcode88
lily/page-spacing.cc:88: return footnote_height
(footnote_height

to preserve indent

http://codereview.appspot.com/4384046/diff/5001/ly/paper-defaults-init.ly
File ly/paper-defaults-init.ly (right):

http://codereview.appspot.com/4384046/diff/5001/ly/paper-defaults-init.ly#new...
ly/paper-defaults-init.ly:111: footnote-footer-padding = 0.5\mm
add to `set-paper-dimension-variables' (same for footnote-padding) otherwise
it's 0.5 staff-space

[mike_apollinemike.com, 2011-04-09 10:34:06]

On Apr 8, 2011, at 5:27 PM, n.puttock@gmail.com wrote:

> LGTM, just needs a regtest.
> 
> 
> http://codereview.appspot.com/4384046/diff/5001/lily/page-spacing.cc
> File lily/page-spacing.cc (right):
> 
> http://codereview.appspot.com/4384046/diff/5001/lily/page-spacing.cc#newcode88
> lily/page-spacing.cc:88: return footnote_height
> (footnote_height
> 
> to preserve indent
> 
> http://codereview.appspot.com/4384046/diff/5001/ly/paper-defaults-init.ly
> File ly/paper-defaults-init.ly (right):
> 
>
http://codereview.appspot.com/4384046/diff/5001/ly/paper-defaults-init.ly#new...
> ly/paper-defaults-init.ly:111: footnote-footer-padding = 0.5\mm
> add to `set-paper-dimension-variables' (same for footnote-padding)
> otherwise it's 0.5 staff-space

Thanks!
Pushed as c676b77a6e685d6efbbeb358f8488725fbab34d2

Cheers,
MS