Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(41)

Issue 4382052: Filter special characters from PS output. Fix 1605 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by Keith
Modified:
13 years ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Filter special characters from PS output. Fix 1605

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M scm/framework-ps.scm View 1 chunk +4 lines, -2 lines 1 comment Download

Messages

Total messages: 5
Keith
This solves the critical bug, but I would like a future patch to replace this ...
13 years ago (2011-04-12 07:04:42 UTC) #1
Valentin Villenave
On 2011/04/12 07:04:42, Keith wrote: > This solves the critical bug, > but I would ...
13 years ago (2011-04-12 07:30:09 UTC) #2
dak
http://codereview.appspot.com/4382052/diff/1/scm/framework-ps.scm File scm/framework-ps.scm (right): http://codereview.appspot.com/4382052/diff/1/scm/framework-ps.scm#newcode412 scm/framework-ps.scm:412: (markup->string val) illegals))))) Apart from creating a new char ...
13 years ago (2011-04-12 07:50:45 UTC) #3
Bertrand Bordage
I made another patch here : http://codereview.appspot.com/4377054/
13 years ago (2011-04-12 10:20:07 UTC) #4
Keith
13 years ago (2011-04-12 17:17:03 UTC) #5
On 2011/04/12 07:30:09, Valentin Villenave wrote:
> Don't we risk losing data because of this? 
Yes, but only in the PDF information fields, the printed words are unchanged.
But the correct solution is...

On 2011/04/12 07:50:45, dak wrote:
> I think one should define a function ps-quote

On 2011/04/12 10:20:07, Bertrand Bordage wrote:
> I made another patch here :
> http://codereview.appspot.com/4377054/

Nice. I'm closing this one.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b