Fix issue 1605

Fix issue 1605

PDF metadata for titles now handle unclosed parentheses.

[Bertrand Bordage, 2011-04-12 10:18:39]

This fixes issue 1605. Keith's patch takes the "\" bug into account. But this
bug also occures with simple markups, so I assume this hasn't to be fixed.

[Bertrand Bordage, 2011-04-12 10:30:39]

Mistake : this produces the right output when we have title = "\a", but PDF
metadata is wrong and only shows "a". I'll include \\ in my next update of the
patch.

[Graham Percival, 2011-04-12 11:09:24]

On Tue, Apr 12, 2011 at 10:30:39AM +0000, bordage.bertrand@gmail.com wrote:
> Mistake : this produces the right output when we have title = "\a", but
> PDF metadata is wrong and only shows "a". I'll include \\ in my next
> update of the patch.

I liked David's idea of having a separate function that did the
quoting (ps-quote ).  Could you integrate that into your next
patch?

Cheers,
- Graham

[Bertrand Bordage, 2011-04-12 11:36:00]

Done. I don't know if this is the correct place for ps-quote.

[Bertrand Bordage, 2011-04-12 11:51:01]

Besides, I noticed two special markups :
\markup "\n" and \markup "\t"
What is their use ? I know \n stands for UNIX carriage return and \t stands for
tab.
But here...
By the way, this doesn't cause any problem with metadata.

[Carl, 2011-04-12 12:55:54]

I'd recommend that the new function be placed in scm/output-ps.scm

Thanks,

Carl

[Bertrand Bordage, 2011-04-12 13:33:05]

How ? output-ps is dependant of framework-ps... When I move it to output-ps, it
doesn't work.

Thanks !
Bertrand

[Carl, 2011-04-12 14:46:54]

On 2011/04/12 13:33:05, Bertrand Bordage wrote:
> How ? output-ps is dependant of framework-ps... When I move it to output-ps,
it
> doesn't work.
> 
Never mind.  I don't know what I was thinking when I made that comment.

Sorry,

Carl

[Keith, 2011-04-12 18:14:54]

Works well for me.

We should probably slip an unmatched parenthesis into the existing
input/regression/pdfmark-metadata.ly

I tested with 
\header {title = "A )little( \"night\" music\nfrom Mozart" }


On 2011/04/12 11:51:01, Bertrand Bordage wrote:
> \markup "\n" and \markup "\t"
> 
The newline and carriage return may be left as literal characters, as opposed to
escape sequences, in the PostScript output.

If you do anything with these, you might double-escape newlines with 
(#\newline "\\\\n")  so the entire string can be seen in the single-line DocInfo
display of a PDF viewer.

[Bertrand Bordage, 2011-04-12 18:40:29]

I added a line to the test. And I don't think we need to do something about
newlines.

[Graham Percival (old account), 2011-04-14 07:50:45]

Could you swap the subject and message?  i.e.  I'd like to have a patch with
first line of the commit being:

PDF metadata for titles now handle unclosed parentheses

I'd also be happy with:

PDF metadata for titles now handle unclosed parentheses (1605)

but as it is, "fix issue 1605" means nothing unless I've memorized the issue
numbers.

Cheers,
- Graham

[hanwenn, 2011-04-18 03:53:45]

On 2011/04/14 07:50:45, Graham Percival wrote:
> Could you swap the subject and message?  i.e.  I'd like to have a patch with
> first line of the commit being:
> 
> PDF metadata for titles now handle unclosed parentheses
> 
> I'd also be happy with:
> 
> PDF metadata for titles now handle unclosed parentheses (1605)
> 
> but as it is, "fix issue 1605" means nothing unless I've memorized the issue
> numbers.
> 
> Cheers,
> - Graham

doesnt  dffe04e8e1a7c0b94fdfc30e44fe141dfbe7cbec already fix this?

[Graham Percival, 2011-04-18 06:15:16]

On Mon, Apr 18, 2011 at 03:53:45AM +0000, hanwenn@gmail.com wrote:
> doesnt  dffe04e8e1a7c0b94fdfc30e44fe141dfbe7cbec already fix this?

That patch follows
ee02cd08e6bf81884323809241013c1834b413ed
which is this (now closed) rietveld issue.

Cheers,
- Graham