Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(171)

Issue 4381045: code review 4381045: 8g: optimize byte mov (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by rsc
Modified:
14 years ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

8g: optimize byte mov Rewrite MOVB with less expensive instruction when possible. Suggested by atomic symbol. benchmark old ns/op new ns/op delta crc32.BenchmarkCrc32KB 13066 3942 -69.83% crc64.BenchmarkCrc64KB 8780 5949 -32.24% lzw.BenchmarkDecoder1e4 771224 636538 -17.46% lzw.BenchmarkDecoder1e5 7101218 6096634 -14.15% lzw.BenchmarkDecoder1e6 69762020 60789400 -12.86% lzw.BenchmarkEncoder1e4 707968 638812 -9.77% lzw.BenchmarkEncoder1e5 6567122 5965552 -9.16% lzw.BenchmarkEncoder1e6 65006000 58911680 -9.38% utf8_test.BenchmarkRuneCountTenASCIIChars 166 165 -0.60% utf8_test.BenchmarkRuneCountTenJapaneseChars 246 258 +4.88% utf8_test.BenchmarkEncodeASCIIRune 13 10 -23.08% utf8_test.BenchmarkEncodeJapaneseRune 37 16 -56.76% utf8_test.BenchmarkDecodeASCIIRune 23 21 -8.70% utf8_test.BenchmarkDecodeJapaneseRune 58 32 -44.83%

Patch Set 1 #

Patch Set 2 : diff -r d13bfb4c642f https://go.googlecode.com/hg #

Patch Set 3 : diff -r 3d599ea0733a https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M src/cmd/8g/peep.c View 1 2 7 chunks +27 lines, -2 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
14 years ago (2011-04-08 17:53:57 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=4fb77130a7ef *** 8g: optimize byte mov Rewrite MOVB with less expensive instruction ...
14 years ago (2011-04-08 17:54:01 UTC) #2
ken3
14 years ago (2011-04-08 21:14:09 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b