Issue 4373057: GL for linux sample app.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4373057: GL for linux sample app. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by Scroggo

Modified:
13 years, 1 month ago

Reviewers:
bsalomon, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Submitted with http://code.google.com/p/skia/source/detail?r=1135

Patch Set 2 : GL for linux sample app #

Total comments: 1

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+388 lines, -122 lines)			Patch
A	gpu/src/unix/GrGLDefaultInterface_unix.cpp	View	1	1 chunk	+170 lines, -0 lines	1 comment	Download
M	gyp/skia.gyp	View		3 chunks	+10 lines, -0 lines	0 comments	Download
M	include/views/SkOSWindow_Unix.h	View		4 chunks	+12 lines, -1 line	0 comments	Download
M	src/utils/unix/SkOSWindow_Unix.cpp	View	1	3 chunks	+186 lines, -10 lines	0 comments	Download
M	unix_test_app/main.cpp	View		3 chunks	+9 lines, -110 lines	0 comments	Download
M	unix_test_app/makefile	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bsalomon

http://codereview.appspot.com/4373057/diff/1/gpu/src/unix/GrGLDefaultInterface_unix.cpp File gpu/src/unix/GrGLDefaultInterface_unix.cpp (right): http://codereview.appspot.com/4373057/diff/1/gpu/src/unix/GrGLDefaultInterface_unix.cpp#newcode122 gpu/src/unix/GrGLDefaultInterface_unix.cpp:122: #if GL_ARB_framebuffer_object I think you should do a has_gl_extension_from_string ...

13 years, 1 month ago (2011-04-12 21:12:46 UTC) #3

Scroggo

13 years, 1 month ago (2011-04-15 14:25:12 UTC) #4

bsalomon

13 years, 1 month ago (2011-04-15 14:34:04 UTC) #5

LGTM.

http://codereview.appspot.com/4373057/diff/6001/gpu/src/unix/GrGLDefaultInter...
File gpu/src/unix/GrGLDefaultInterface_unix.cpp (right):

http://codereview.appspot.com/4373057/diff/6001/gpu/src/unix/GrGLDefaultInter...
gpu/src/unix/GrGLDefaultInterface_unix.cpp:142:
GR_GL_GET_PROC_SUFFIX(GenFramebuffers, EXT);
If the functions are declared it's OK to just do
gDefaultInterface.fGenFramebuffers = glGenFramebuffersEXT here as you had
before. But it doesn't matter either way.

Expand All Messages | Collapse All Messages