Issue 4368076: code review 4368076: pkg/runtime/plan9: Warning remediation, for Plan 9 native.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4368076: code review 4368076: pkg/runtime/plan9: Warning remediation, for Plan 9 native. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by lucio

Modified:
14 years ago

Reviewers:

CC:
golang-dev, r, r2

Visibility:
Public.

Description

pkg/runtime/plan9: Warning remediation, for Plan 9 native. . Missing declaration of runtime.brk_(); . Argument v in runtime.SysReserve() is not used; (I'd prefer a Plan 9-type solution...)

Patch Set 2 : diff -r 8e011ae43486 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8e011ae43486 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 79173f40bb9d https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/pkg/runtime/plan9/mem.c	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

lucio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-04-12 08:57:47 UTC) #1

http://codereview.appspot.com/4368076/diff/3001/src/pkg/runtime/plan9/mem.c File src/pkg/runtime/plan9/mem.c (right): http://codereview.appspot.com/4368076/diff/3001/src/pkg/runtime/plan9/mem.c#newcode7 src/pkg/runtime/plan9/mem.c:7: #include "os.h" why is this needed?

14 years ago (2011-04-12 18:01:42 UTC) #2

lucio

There's a missing declaration of runtime·brk_() if os.h is not included. I'll try to put ...

14 years ago (2011-04-13 03:19:13 UTC) #3

On Apr 12, 2011, at 8:19 PM, Lucio De Re wrote: > There's a missing ...

14 years ago (2011-04-13 03:19:56 UTC) #4

lucio

Hello golang-dev@googlegroups.com, r, r2 (cc: golang-dev@googlegroups.com), Please take another look.

14 years ago (2011-04-13 03:36:44 UTC) #5

14 years ago (2011-04-14 18:54:38 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=2e0db11af6b0 ***

pkg/runtime/plan9: Warning remediation, for Plan 9 native.

. Missing declaration of runtime.brk_();
. Argument v in runtime.SysReserve() is not used;
  (I'd prefer a Plan 9-type solution...)

R=golang-dev, r, r2
CC=golang-dev
http://codereview.appspot.com/4368076

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages