Issue 4368069: code review 4368069: goprotobuf: hand-edit the gofix changes for nicer code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4368069: code review 4368069: goprotobuf: hand-edit the gofix changes for nicer code (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by r

Modified:
14 years, 7 months ago

Reviewers:
rsc

CC:
dsymonds, golang-dev

Visibility:
Public.

Description

goprotobuf: hand-edit the gofix changes for nicer code and clean up a few details. No semantic change.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r ea84b246d69b https://goprotobuf.googlecode.com/hg/ #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -36 lines)			Patch
M	proto/encode.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	proto/properties.go	View	2 chunks	+20 lines, -31 lines	0 comments	Download
M	proto/text.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	proto/text_parser.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello rsc, dsymonds (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://goprotobuf.googlecode.com/hg/

14 years, 7 months ago (2011-04-11 20:00:46 UTC) #1

*** Submitted as http://code.google.com/p/goprotobuf/source/detail?r=8d0682e7ba92 *** goprotobuf: hand-edit the gofix changes for nicer code and clean ...

14 years, 7 months ago (2011-04-11 23:14:57 UTC) #3

rsc

14 years, 7 months ago (2011-04-11 23:15:25 UTC) #4

http://codereview.appspot.com/4368069/diff/1/proto/text_parser.go
File proto/text_parser.go (right):

http://codereview.appspot.com/4368069/diff/1/proto/text_parser.go#newcode389
proto/text_parser.go:389: case reflect.Int32, reflect.Int64:
sb

case reflect.Int32:
    ...
case reflect.Int64:
   ...

http://codereview.appspot.com/4368069/diff/1/proto/text_parser.go#newcode436
proto/text_parser.go:436: case reflect.Uint32, reflect.Uint64:
same

Expand All Messages | Collapse All Messages