Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83)

Issue 4368063: code review 4368063: gofmt: added test framework in Go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by gri
Modified:
14 years ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

gofmt: add test framework in Go - replaced existing testdata/test.sh with new gofmt_test - added initial test case for rewrite tests TODO: Need to add more tests.

Patch Set 1 #

Patch Set 2 : diff -r 9a64273f9d68 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9a64273f9d68 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9a64273f9d68 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 54b2790403aa https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r be97234e0e4e https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r be97234e0e4e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -65 lines) Patch
A src/cmd/gofmt/gofmt_test.go View 1 2 3 4 1 chunk +81 lines, -0 lines 0 comments Download
A src/cmd/gofmt/testdata/rewrite1.golden View 1 1 chunk +8 lines, -0 lines 0 comments Download
A src/cmd/gofmt/testdata/rewrite1.input View 1 1 chunk +8 lines, -0 lines 0 comments Download
R src/cmd/gofmt/testdata/test.sh View 1 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 6
gri
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years ago (2011-04-10 00:18:49 UTC) #1
rsc
Exec'ing gofmt is probably not the right approach except for testing command-line processing. If you ...
14 years ago (2011-04-13 13:34:03 UTC) #2
gri
PTAL - gri On Wed, Apr 13, 2011 at 6:34 AM, <rsc@golang.org> wrote: > Exec'ing ...
14 years ago (2011-04-13 20:45:39 UTC) #3
rsc
LGTM
14 years ago (2011-04-13 20:54:20 UTC) #4
rsc
if you get this before the submit, s/added/add/ in CL description
14 years ago (2011-04-13 20:54:48 UTC) #5
gri
14 years ago (2011-04-13 21:00:03 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=b56f308973d8 ***

gofmt: add test framework in Go

- replaced existing testdata/test.sh with new gofmt_test
- added initial test case for rewrite tests

TODO: Need to add more tests.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4368063
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b