Issue 4366047: code review 4366047: ld: fix Plan 9 symbol table

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4366047: code review 4366047: ld: fix Plan 9 symbol table (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by ality

Modified:
14 years, 6 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

ld: fix Plan 9 symbol table Static symbols were not being marked as such. I also made the 'z' symbols use the first byte of the name instead of an explicit NUL so that if the symbol table format is ever changed, the only place that would need updating is addhist().

Patch Set 1 #

Patch Set 2 : diff -r 872404d61597 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 872404d61597 https://go.googlecode.com/hg/ #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -13 lines)			Patch
	M	src/cmd/ld/symtab.c	View	1	2 chunks	+7 lines, -13 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ality

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 6 months ago (2011-04-10 06:36:54 UTC) #1

rsc

14 years, 6 months ago (2011-04-23 14:53:54 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=4d08a61cd718 ***

ld: fix Plan 9 symbol table

Static symbols were not being marked as such.

I also made the 'z' symbols use the first byte of
the name instead of an explicit NUL so that if
the symbol table format is ever changed, the only
place that would need updating is addhist().

R=rsc
CC=golang-dev
http://codereview.appspot.com/4366047

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages