Issue 4354048: Remove dependence on platform GL to build Gr, add optional platform-specific default impls

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4354048: Remove dependence on platform GL to build Gr, add optional platform-specific default impls (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by bsalomon

Modified:
15 years ago

Reviewers:
twiz1, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

This enables us to build skia in Chrome without a dependency on the gles2 lib.

Patch Set 2 : minor changes #

Total comments: 2

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+491 lines, -564 lines)			Patch
M	Makefile	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	gpu/include/GrGLConfig.h	View		4 chunks	+24 lines, -18 lines	0 comments	Download
M	gpu/include/GrGLConfig_chrome.h	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	gpu/include/GrGLIRect.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/include/GrGLIndexBuffer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/include/GrGLInterface.h	View		8 chunks	+26 lines, -9 lines	1 comment	Download
D	gpu/include/GrGLPlatformIncludes.h	View		1 chunk	+0 lines, -204 lines	0 comments	Download
M	gpu/include/GrGLVertexBuffer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
A	gpu/src/GrGLDefaultInterface_none.cpp	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	gpu/src/GrGLInterface.cpp	View		3 chunks	+5 lines, -301 lines	1 comment	Download
M	gpu/src/GrGLUtil.cpp	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	gpu/src/GrGpuFactory.cpp	View		1 chunk	+13 lines, -4 lines	0 comments	Download
M	gpu/src/GrGpuGL.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
A	gpu/src/mac/GrGLDefaultInterface_mac.cpp	View	1	1 chunk	+148 lines, -0 lines	0 comments	Download
A	gpu/src/win/GrGLDefaultInterface_win.cpp	View	1	1 chunk	+178 lines, -0 lines	0 comments	Download
M	gyp/skia.gyp	View	1	8 chunks	+25 lines, -2 lines	0 comments	Download
M	vs/SampleApp/SampleApp.vcxproj	View		6 chunks	+10 lines, -3 lines	0 comments	Download
M	vs/SampleApp/SampleApp.vcxproj.filters	View		3 chunks	+22 lines, -1 line	0 comments	Download
M	xcode/gpu/gpu.xcodeproj/project.pbxproj	View		8 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

twiz1

LGTM http://codereview.appspot.com/4354048/diff/2001/gpu/include/GrGLInterface.h File gpu/include/GrGLInterface.h (right): http://codereview.appspot.com/4354048/diff/2001/gpu/include/GrGLInterface.h#newcode303 gpu/include/GrGLInterface.h:303: // make this the last entry in the ...

15 years ago (2011-04-04 16:59:31 UTC) #3

bsalomon

15 years ago (2011-04-04 17:29:06 UTC) #4

thanks for the reviews! Checked in as r1045, closed. 

On 2011/04/04 16:59:31, twiz1 wrote:
> LGTM
> 
> http://codereview.appspot.com/4354048/diff/2001/gpu/include/GrGLInterface.h
> File gpu/include/GrGLInterface.h (right):
> 
>
http://codereview.appspot.com/4354048/diff/2001/gpu/include/GrGLInterface.h#n...
> gpu/include/GrGLInterface.h:303: // make this the last entry in the statc
> initializer. It can help to guard
> static
> 
> http://codereview.appspot.com/4354048/diff/2001/gpu/src/GrGLInterface.cpp
> File gpu/src/GrGLInterface.cpp (right):
> 
>
http://codereview.appspot.com/4354048/diff/2001/gpu/src/GrGLInterface.cpp#new...
> gpu/src/GrGLInterface.cpp:86:
> GrGLGetGLInterface()->fGetString(GR_GL_EXTENSIONS));
> Good catch.

Expand All Messages | Collapse All Messages