Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(141)

Issue 4354048: Remove dependence on platform GL to build Gr, add optional platform-specific default impls (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by bsalomon
Modified:
13 years, 8 months ago
Reviewers:
twiz1, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This enables us to build skia in Chrome without a dependency on the gles2 lib.

Patch Set 1 #

Patch Set 2 : minor changes #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+491 lines, -564 lines) Patch
M Makefile View 2 chunks +4 lines, -0 lines 0 comments Download
M gpu/include/GrGLConfig.h View 4 chunks +24 lines, -18 lines 0 comments Download
M gpu/include/GrGLConfig_chrome.h View 1 chunk +0 lines, -14 lines 0 comments Download
M gpu/include/GrGLIRect.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/include/GrGLIndexBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/include/GrGLInterface.h View 8 chunks +26 lines, -9 lines 1 comment Download
D gpu/include/GrGLPlatformIncludes.h View 1 chunk +0 lines, -204 lines 0 comments Download
M gpu/include/GrGLVertexBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
A gpu/src/GrGLDefaultInterface_none.cpp View 1 chunk +18 lines, -0 lines 0 comments Download
M gpu/src/GrGLInterface.cpp View 3 chunks +5 lines, -301 lines 1 comment Download
M gpu/src/GrGLUtil.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
M gpu/src/GrGpuFactory.cpp View 1 chunk +13 lines, -4 lines 0 comments Download
M gpu/src/GrGpuGL.h View 1 chunk +0 lines, -1 line 0 comments Download
A gpu/src/mac/GrGLDefaultInterface_mac.cpp View 1 1 chunk +148 lines, -0 lines 0 comments Download
A gpu/src/win/GrGLDefaultInterface_win.cpp View 1 1 chunk +178 lines, -0 lines 0 comments Download
M gyp/skia.gyp View 1 8 chunks +25 lines, -2 lines 0 comments Download
M vs/SampleApp/SampleApp.vcxproj View 6 chunks +10 lines, -3 lines 0 comments Download
M vs/SampleApp/SampleApp.vcxproj.filters View 3 chunks +22 lines, -1 line 0 comments Download
M xcode/gpu/gpu.xcodeproj/project.pbxproj View 8 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4
bsalomon
13 years, 8 months ago (2011-04-04 15:18:46 UTC) #1
reed1
LGTM
13 years, 8 months ago (2011-04-04 15:32:39 UTC) #2
twiz1
LGTM http://codereview.appspot.com/4354048/diff/2001/gpu/include/GrGLInterface.h File gpu/include/GrGLInterface.h (right): http://codereview.appspot.com/4354048/diff/2001/gpu/include/GrGLInterface.h#newcode303 gpu/include/GrGLInterface.h:303: // make this the last entry in the ...
13 years, 8 months ago (2011-04-04 16:59:31 UTC) #3
bsalomon
13 years, 8 months ago (2011-04-04 17:29:06 UTC) #4
thanks for the reviews! Checked in as r1045, closed. 

On 2011/04/04 16:59:31, twiz1 wrote:
> LGTM
> 
> http://codereview.appspot.com/4354048/diff/2001/gpu/include/GrGLInterface.h
> File gpu/include/GrGLInterface.h (right):
> 
>
http://codereview.appspot.com/4354048/diff/2001/gpu/include/GrGLInterface.h#n...
> gpu/include/GrGLInterface.h:303: // make this the last entry in the statc
> initializer. It can help to guard
> static
> 
> http://codereview.appspot.com/4354048/diff/2001/gpu/src/GrGLInterface.cpp
> File gpu/src/GrGLInterface.cpp (right):
> 
>
http://codereview.appspot.com/4354048/diff/2001/gpu/src/GrGLInterface.cpp#new...
> gpu/src/GrGLInterface.cpp:86:
> GrGLGetGLInterface()->fGetString(GR_GL_EXTENSIONS));
> Good catch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b