Issue 4344066: code review 4344066: ld: Handle Mach-O X86_64_RELOC_SIGNED relocations that ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4344066: code review 4344066: ld: Handle Mach-O X86_64_RELOC_SIGNED relocations that ...

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by mkrautz

Modified:
14 years, 1 month ago

Reviewers:
rsc

CC:
rsc, golang-dev

Visibility:
Public.

Description

ld: Handle Mach-O X86_64_RELOC_SIGNED relocations that reference a section. Fixes issue 1658.

Patch Set 1 #

Patch Set 2 : diff -r f782663275a7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6c96d1022285 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6c96d1022285 https://go.googlecode.com/hg/ #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -2 lines)			Patch
	M	src/cmd/ld/ldmacho.c	View	1 2 3	2 chunks	+24 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mkrautz

This fixes issue 1658 (cgo/darwin-amd64: Contant float/double values incorrectly initialized for statically linked objects.) Perhaps ...

14 years, 1 month ago (2011-04-04 21:29:07 UTC) #1

rsc

This looks great, and thanks very much for finding it! Could you move the uint64 ...

14 years, 1 month ago (2011-04-04 23:14:57 UTC) #2

mkrautz

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 1 month ago (2011-04-05 06:52:51 UTC) #3

rsc

14 years, 1 month ago (2011-04-07 18:20:46 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=1e5952da8be6 ***

ld: fix Mach-O X86_64_RELOC_SIGNED relocations

Fixes issue 1658.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4344066

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages