code review 4336042: govet: fix bug introduced at 4313054

govet: fix bug introduced at 4313054

[r, 2011-03-29 20:00:09]

Hello rsc, gri (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-03-29 20:03:04]

LGTM

[gri, 2011-03-29 20:06:05]

LGTM

My apologies.
- gri

On Tue, Mar 29, 2011 at 1:00 PM,  <r@golang.org> wrote:
> Reviewers: rsc, gri,
>
> Message:
> Hello rsc, gri (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> govet: fix bug introduced at 4313054
>
> Please review this at http://codereview.appspot.com/4336042/
>
> Affected files:
>  M src/cmd/govet/govet.go
>
>
> Index: src/cmd/govet/govet.go
> ===================================================================
> --- a/src/cmd/govet/govet.go
> +++ b/src/cmd/govet/govet.go
> @@ -256,7 +256,7 @@
>                return
>        }
>        if lit.Kind == token.STRING {
> -               if strings.Contains(lit.Value, "%") {
> +               if !strings.Contains(lit.Value, "%") {
>                        if len(call.Args) > skip+1 {
>                                f.Badf(call.Pos(), "no formatting directive
> in %s call", name)
>                        }
>
>
>

[r, 2011-03-29 20:18:57]

*** Submitted as http://code.google.com/p/go/source/detail?r=f913f91d2703 ***

govet: fix bug introduced at 4313054

R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/4336042