Issue 4331050: code review 4331050: syscall: add BPF support for freebsd/386, freebsd/amd64

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4331050: code review 4331050: syscall: add BPF support for freebsd/386, freebsd/amd64 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by mikio

Modified:
14 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

syscall: add BPF support for freebsd/386, freebsd/amd64

Patch Set 2 : diff -r 9bb646cecf58 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9bb646cecf58 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 9bb646cecf58 https://go.googlecode.com/hg/ #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2141 lines, -1599 lines)			Patch
M	src/pkg/syscall/mkerrors.sh	View	1	3 chunks	+5 lines, -1 line	0 comments	Download
M	src/pkg/syscall/types_freebsd.c	View	1	2 chunks	+21 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zerrors_freebsd_386.go	View	1	1 chunk	+1007 lines, -799 lines	0 comments	Download
M	src/pkg/syscall/zerrors_freebsd_amd64.go	View	1	1 chunk	+1007 lines, -799 lines	0 comments	Download
M	src/pkg/syscall/ztypes_freebsd_386.go	View	1	2 chunks	+50 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/ztypes_freebsd_amd64.go	View	1	2 chunks	+51 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 1 month ago (2011-03-31 13:34:45 UTC) #1

rsc

No system call wrappers? Or are those system calls unrelated? http://codereview.appspot.com/4331050/diff/3001/src/pkg/syscall/zsysnum_freebsd_amd64.go File src/pkg/syscall/zsysnum_freebsd_amd64.go (right): http://codereview.appspot.com/4331050/diff/3001/src/pkg/syscall/zsysnum_freebsd_amd64.go#newcode320 ...

14 years, 1 month ago (2011-03-31 14:45:48 UTC) #2

mikio

On Thu, Mar 31, 2011 at 4:45 PM, <rsc@golang.org> wrote: > No system call wrappers? ...

14 years, 1 month ago (2011-03-31 15:03:45 UTC) #3

mikio

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 1 month ago (2011-03-31 16:45:46 UTC) #4

rsc

14 years, 1 month ago (2011-04-04 19:40:46 UTC) #6

*** Submitted as bf72f0b895ff ***

syscall: add BPF support for freebsd/386, freebsd/amd64

R=rsc
CC=golang-dev
http://codereview.appspot.com/4331050

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages