Issue 4322041: code review 4322041: fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4322041: code review 4322041: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by rsc

Modified:
14 years, 1 month ago

Reviewers:

CC:
adg, golang-dev

Visibility:
Public.

Description

fix build

Patch Set 1 #

Patch Set 2 : diff -r 350b8ea587b8 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 350b8ea587b8 https://go.googlecode.com/hg/ #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/net/file_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 1 month ago (2011-03-29 03:39:38 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=3ea2469165ac *** fix build TBR=adg CC=golang-dev http://codereview.appspot.com/4322041

14 years, 1 month ago (2011-03-29 03:39:42 UTC) #2

adg

14 years, 1 month ago (2011-03-29 03:41:42 UTC) #3

LGTM

On 29 March 2011 14:39,  <rsc@golang.org> wrote:
> Reviewers: adg,
>
> Message:
> Hello adg (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> fix build
>
> Please review this at http://codereview.appspot.com/4322041/
>
> Affected files:
>  M src/pkg/net/file_test.go
>
>
> Index: src/pkg/net/file_test.go
> ===================================================================
> --- a/src/pkg/net/file_test.go
> +++ b/src/pkg/net/file_test.go
> @@ -105,7 +105,7 @@
>  }
>
>  func testFilePacketConnDial(t *testing.T, net, raddr string) {
> -       c, err := Dial(net, "", raddr)
> +       c, err := Dial(net, raddr)
>        if err != nil {
>                t.Fatalf("Dial failed: %v", err)
>        }
>
>
>

Expand All Messages | Collapse All Messages