Issue 4316054: code review 4316054: path/filepath: add support for plan9

Issue 4316054: code review 4316054: path/filepath: add support for plan9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by aam

Modified:
14 years ago

Reviewers:

CC:
paulzhol, ality, r, fhs, golang-dev

Visibility:
Public.

Patch Set 2 : diff -r f0f78e666988 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f0f78e666988 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f949db3f967b https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r f949db3f967b https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r f949db3f967b https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 7 : diff -r f949db3f967b https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -1 line)			Patch
M	src/pkg/path/filepath/Makefile	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
A	src/pkg/path/filepath/path_plan9.go	View	1 2 3 4 5 6	1 chunk	+28 lines, -0 lines	0 comments	Download
M	src/pkg/path/filepath/path_unix.go	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 11

Expand All Messages | Collapse All Messages

aam

Hello paulzhol (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-04-03 00:16:34 UTC) #1

ality

This isn't quite right. Rc delimits lists with NUL so if you were to do, ...

14 years ago (2011-04-03 01:11:47 UTC) #2

aam

Hello paulzhol, ality (cc: golang-dev@googlegroups.com), Please take another look.

14 years ago (2011-04-03 15:43:12 UTC) #3

http://codereview.appspot.com/4316054/diff/6001/src/pkg/path/filepath/path_plan9.go File src/pkg/path/filepath/path_plan9.go (right): http://codereview.appspot.com/4316054/diff/6001/src/pkg/path/filepath/path_plan9.go#newcode25 src/pkg/path/filepath/path_plan9.go:25: // It returns "" on Unix. maybe s/on Unix/elsewhere/ ...

14 years ago (2011-04-03 15:50:16 UTC) #4

aam

Hello paulzhol, ality, r (cc: golang-dev@googlegroups.com), Please take another look.

14 years ago (2011-04-03 15:53:21 UTC) #6

aam

Hello paulzhol, ality, r (cc: golang-dev@googlegroups.com), Please take another look.

14 years ago (2011-04-03 15:54:06 UTC) #7

fhs

http://codereview.appspot.com/4316054/diff/7006/src/pkg/path/filepath/path_plan9.go File src/pkg/path/filepath/path_plan9.go (right): http://codereview.appspot.com/4316054/diff/7006/src/pkg/path/filepath/path_plan9.go#newcode21 src/pkg/path/filepath/path_plan9.go:21: return strings.HasPrefix(path, "/") What about paths beginning with '#'?

14 years ago (2011-04-03 15:56:05 UTC) #8

aam

Hello paulzhol, ality, r, fhs (cc: golang-dev@googlegroups.com), Please take another look.

14 years ago (2011-04-03 16:03:31 UTC) #9

14 years ago (2011-04-03 16:11:45 UTC) #11

*** Submitted as http://code.google.com/p/go/source/detail?r=11611373ac8a ***

path/filepath: add support for plan9

R=paulzhol, ality, r, fhs
CC=golang-dev
http://codereview.appspot.com/4316054

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages