Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(391)

Issue 4313047: Suppress continuing LyricHyphen under grace note at start of line (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by Trevor Daniels
Modified:
12 years, 11 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Suppress continuing LyricHyphen under grace note at start of line - fixes 688

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changes suggested by Neil #

Patch Set 3 : Alternative fix using kill-zero-spanned-time callback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -40 lines) Patch
M input/regression/lyric-hyphen-grace.ly View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lily/include/moment.hh View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M lily/lyric-hyphen.cc View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
M lily/moment.cc View 1 2 2 chunks +1 line, -12 lines 0 comments Download
M lily/spanner.cc View 1 2 8 chunks +11 lines, -11 lines 0 comments Download
M scm/define-grobs.scm View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12
Trevor Daniels
This is a suggested fix for issue 688: http://code.google.com/p/lilypond/issues/detail?id=688 Reg tests look OK. The output ...
13 years ago (2011-03-24 18:45:40 UTC) #1
Graham Percival (old account)
LGTM
13 years ago (2011-03-26 14:43:11 UTC) #2
Graham Percival (old account)
Time for complaints is over; please push.
13 years ago (2011-03-28 14:02:59 UTC) #3
Trevor Daniels
Pushed. 2fb262fb403b75907bdebbaf7fbb819733bf6355
13 years ago (2011-03-28 15:56:46 UTC) #4
Neil Puttock
Hi Trevor, I hope you don't mind the following late comments. :) Cheers, Neil http://codereview.appspot.com/4313047/diff/1/input/regression/lyric-hyphen-grace.ly ...
13 years ago (2011-03-28 20:17:29 UTC) #5
t.daniels_treda.co.uk
n.puttock@gmail.com wrote Monday, March 28, 2011 9:17 PM > I hope you don't mind the ...
13 years ago (2011-03-28 22:44:55 UTC) #6
Neil Puttock
On 2011/03/28 22:44:55, t.daniels_treda.co.uk wrote: > > http://codereview.appspot.com/4313047/diff/1/lily/lyric-hyphen.cc#newcode46 > > lily/lyric-hyphen.cc:46: if (Paper_column::when_mom > > ...
13 years ago (2011-03-29 22:30:29 UTC) #7
Trevor Daniels
Patch set 3 follows up on Neil's suggestion to use the kill-zero-spanned-time callback. This patch ...
13 years ago (2011-03-31 16:12:37 UTC) #8
Graham Percival (old account)
LGTM, I can confirm the clean regtests.
13 years ago (2011-04-01 15:41:00 UTC) #9
lilypond.patches
Patch listed.
13 years ago (2011-04-01 16:51:00 UTC) #10
Graham Percival (old account)
ok, deadline definitely passed. Please push.
12 years, 11 months ago (2011-04-08 03:14:21 UTC) #11
Trevor Daniels
12 years, 11 months ago (2011-04-09 09:55:17 UTC) #12
Pushed as two commits, one to revert the earlier fix:
76490755dae238028e919653057f231b25be3445

and one to apply the new fix
2aa1d6f450a7f051aa4b0ddcaf89593f7ff23a60
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b