Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1284)

Issue 4312058: Adds beam collision avoidance to auto-beaming (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by MikeSol
Modified:
13 years, 1 month ago
Reviewers:
mike, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Adds beam collision avoidance to auto-beaming

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -15 lines) Patch
M lily/auto-beam-engraver.cc View 6 chunks +7 lines, -0 lines 0 comments Download
M lily/beam.cc View 1 chunk +1 line, -0 lines 0 comments Download
M lily/beam-collision-engraver.cc View 6 chunks +82 lines, -15 lines 0 comments Download
M scm/define-grob-properties.scm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
MikeSol
I think this is a better approach to getting beam collision resolution out of auto-beams. ...
13 years, 1 month ago (2011-03-26 21:28:27 UTC) #1
hanwenn
On Sat, Mar 26, 2011 at 6:28 PM, <mtsolo@gmail.com> wrote: > Reviewers: , > > ...
13 years, 1 month ago (2011-03-26 21:46:16 UTC) #2
mike_apollinemike.com
On Mar 26, 2011, at 5:46 PM, Han-Wen Nienhuys wrote: > On Sat, Mar 26, ...
13 years, 1 month ago (2011-03-26 21:54:44 UTC) #3
hanwenn
13 years, 1 month ago (2011-03-26 21:56:25 UTC) #4
On Sat, Mar 26, 2011 at 6:54 PM, mike@apollinemike.com
<mike@apollinemike.com> wrote:

>> Quick comment: I'd say that timestep-count as a property is not
>> necessary.  The 'width' of an autobeam could also be garnered by
>> looking at its bounds, eg beam->get_bound(LEFT)-> get_column().  From
>> the column you could either look at rank or when.
>>
>> A completely different approach now comes to mind: there is no strict
>> need to do all this processing 'on-line'.  You could also have the
>> engraver collect a list of grobs + timing-ranges in a list.  In
>> finalize(), you could sort the list, and decide which grobs to add
>> where.

> This sounds like a great idea.  Do you have time to write something along
those lines?

Unfortunately, no.

-- 
Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b