Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(574)

Issue 4312055: code review 4312055: test: match gccgo error messages for bug016.go. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by iant
Modified:
14 years, 1 month ago
Reviewers:
CC:
rsc, gri, golang-dev
Visibility:
Public.

Description

test: match gccgo error messages for bug016.go. bug016.go:11:8: error: negative shift count

Patch Set 1 #

Patch Set 2 : diff -r f09e729299f4 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/fixedbugs/bug016.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
iant
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 1 month ago (2011-03-25 19:27:20 UTC) #1
gri
LGTM On Fri, Mar 25, 2011 at 12:27 PM, <iant@golang.org> wrote: > Reviewers: rsc, > ...
14 years, 1 month ago (2011-03-25 19:33:39 UTC) #2
rsc
LGTM
14 years, 1 month ago (2011-03-25 19:51:04 UTC) #3
iant
14 years, 1 month ago (2011-03-25 20:31:35 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=56b847e640f3 ***

test: match gccgo error messages for bug016.go.

bug016.go:11:8: error: negative shift count

R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/4312055
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b