Issue 4312043: Fix 1569: Bad behavior of NoteNames context

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4312043: Fix 1569: Bad behavior of NoteNames context (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by Carl

Modified:
13 years ago

Reviewers:
Graham Percival (old account)

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix 1569: Bad behavior of NoteNames context Changed default value of 'staff-affinity to #UP Changed default spacing parameters to be the same as for Lyrics context Added some documentation about spacing of nonstaff lines to help users better understand nonstaff line spacing. Added regression test file

Patch Set 1 : Initial patch #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -25 lines)			Patch
M	Documentation/notation/spacing.itely	View	2 chunks	+9 lines, -4 lines	0 comments	Download
M	input/regression/note-names.ly	View	1 chunk	+29 lines, -19 lines	0 comments	Download
M	ly/engraver-init.ly	View	1 chunk	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Carl

Here's a proposed patch for Issue 1569. Please review. Thanks, Carl

13 years, 1 month ago (2011-03-22 22:32:38 UTC) #1

LGTM, please push.

Expand All Messages | Collapse All Messages