Issue 4306047: code review 4306047: runtime: more stack split fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4306047: code review 4306047: runtime: more stack split fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by rsc

Modified:
14 years, 9 months ago

Reviewers:

CC:
lvd, golang-dev

Visibility:
Public.

Description

runtime: more stack split fixes Found by stkcheck after 6l, 8l bug fixes Luuk is about to submit.

Patch Set 1 #

Patch Set 2 : diff -r 3be3d3cd4b7f https://go.googlecode.com/hg #

Patch Set 3 : diff -r 3be3d3cd4b7f https://go.googlecode.com/hg #

Patch Set 4 : diff -r 3be3d3cd4b7f https://go.googlecode.com/hg #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -44 lines)			Patch
	M	src/pkg/runtime/chan.c	View	1	4 chunks	+46 lines, -44 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello lvd (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

14 years, 9 months ago (2011-03-23 15:18:45 UTC) #1

rsc

14 years, 9 months ago (2011-03-23 15:28:33 UTC) #3

*** Submitted as 7855791cf9f6 ***

runtime: more stack split fixes

Found by stkcheck after 6l, 8l bug fixes Luuk is about to submit.

R=lvd
CC=golang-dev
http://codereview.appspot.com/4306047

Expand All Messages | Collapse All Messages