Issue 4300053: code review 4300053: gotype: support for more tests, added one new test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4300053: code review 4300053: gotype: support for more tests, added one new test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by gri

Modified:
14 years, 1 month ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

gotype: support for more tests, added one new test also: minor fix to parser Note: gotest won't run the gotype test yet until it permits TestXXX functions where XXX is empty.

Patch Set 1 #

Patch Set 2 : diff -r 37a8da2ac3f2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 37a8da2ac3f2 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 37a8da2ac3f2 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r d4a8eff854f6 https://go.googlecode.com/hg/ #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -9 lines)			Patch
M	src/cmd/gotype/gotype_test.go	View	1 2	1 chunk	+27 lines, -7 lines	0 comments	Download
A	src/cmd/gotype/testdata/test1.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/pkg/go/parser/parser.go	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 1 month ago (2011-03-30 18:37:15 UTC) #1

gri

14 years, 1 month ago (2011-03-30 22:27:25 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=cf1342f0c8bd ***

gotype: support for more tests, added one new test

also: minor fix to parser

Note: gotest won't run the gotype test yet until
it permits TestXXX functions where XXX is empty.

R=r
CC=golang-dev
http://codereview.appspot.com/4300053

Expand All Messages | Collapse All Messages