Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2972)

Issue 4298048: Support for run-time selection between GLES and Desktop GL implementations. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by twiz1
Modified:
13 years, 7 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This CL removes the compile-time selection of the GL implementation based on the GR_SUPPORT_GLDESKTOP family of macros. Support for the platform is configured dynamically, by querying the fBindingsExported member of active GrGLInterface instance. Committed: http://code.google.com/p/skia/source/detail?r=960

Patch Set 1 #

Patch Set 2 : Remove GR_SUPPORT_GLXXXX defintions to prevent accidental use. #

Patch Set 3 : Re-baseline to r959 #

Patch Set 4 : Correct run-time selection of ES1 and ES2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -246 lines) Patch
M gpu/include/GrGLConfig.h View 1 2 3 2 chunks +18 lines, -5 lines 0 comments Download
M gpu/include/GrGLInterface.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M gpu/include/GrGLPlatformIncludes.h View 1 2 2 chunks +13 lines, -7 lines 0 comments Download
M gpu/include/GrGLTexture.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/src/GrGLInterface.cpp View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M gpu/src/GrGLTexture.cpp View 1 2 1 chunk +18 lines, -8 lines 0 comments Download
M gpu/src/GrGpuFactory.cpp View 1 2 3 chunks +2 lines, -15 lines 0 comments Download
M gpu/src/GrGpuGL.cpp View 1 2 15 chunks +182 lines, -179 lines 0 comments Download
M gpu/src/GrGpuGLFixed.cpp View 1 2 3 chunks +6 lines, -11 lines 0 comments Download
M gpu/src/GrGpuGLShaders2.cpp View 1 2 7 chunks +30 lines, -20 lines 0 comments Download

Messages

Total messages: 2
twiz1
PTAL. Note that this change currently pulls in the changes required to remove dependency on ...
13 years, 7 months ago (2011-03-18 06:33:18 UTC) #1
bsalomon
13 years, 7 months ago (2011-03-18 13:46:30 UTC) #2
Jeff, you're a hero! :)

This looks great. 

I just remembered something we'll want to address in the long term. This isn't
worth holding up Chrome work for, though. On some ES platforms (ios) the headers
and GL runtime are structured so that an app can include both headers. Functions
that are in both ES1 and ES2 are handled at runtime based on the version of the
current context. So I think we really just want ES vs Desktop as opposed to a
tri-state for GrGLBinding. But like I said it isn't important in the short-run.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b