Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1932)

Issue 4272061: Removal of all GL header dependencies in Ganesh. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by twiz1
Modified:
13 years, 8 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This CL removes all dependencies on GL headers across all of Ganesh. New GrGLint, etc. types are introduced, and new GR_GL_XXXX constants for use at all GL call-sites. Committed: http://code.google.com/p/skia/source/detail?r=959

Patch Set 1 #

Patch Set 2 : Addition of Xcode project changes. #

Total comments: 2

Patch Set 3 : Remove changes to SkUIView.h #

Patch Set 4 : Correct Chrome #defines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1247 lines, -882 lines) Patch
M gpu/include/GrGLConfig.h View 5 chunks +8 lines, -7 lines 0 comments Download
M gpu/include/GrGLConfig_chrome.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A gpu/include/GrGLDefines.h View 1 chunk +628 lines, -0 lines 0 comments Download
M gpu/include/GrGLIRect.h View 2 chunks +24 lines, -7 lines 0 comments Download
M gpu/include/GrGLIndexBuffer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M gpu/include/GrGLInterface.h View 2 chunks +108 lines, -92 lines 0 comments Download
M gpu/include/GrGLPlatformIncludes.h View 7 chunks +32 lines, -355 lines 0 comments Download
M gpu/include/GrGLTexture.h View 9 chunks +30 lines, -30 lines 0 comments Download
M gpu/include/GrGLVertexBuffer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M gpu/src/GrGLIndexBuffer.cpp View 7 chunks +14 lines, -14 lines 0 comments Download
M gpu/src/GrGLInterface.cpp View 3 chunks +30 lines, -12 lines 0 comments Download
M gpu/src/GrGLTexture.cpp View 3 chunks +11 lines, -11 lines 0 comments Download
M gpu/src/GrGLUtil.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gpu/src/GrGLVertexBuffer.cpp View 7 chunks +14 lines, -14 lines 0 comments Download
M gpu/src/GrGpuGL.h View 2 chunks +5 lines, -5 lines 0 comments Download
M gpu/src/GrGpuGL.cpp View 61 chunks +233 lines, -233 lines 0 comments Download
M gpu/src/GrGpuGLFixed.cpp View 14 chunks +49 lines, -49 lines 0 comments Download
M gpu/src/GrGpuGLShaders2.h View 2 chunks +5 lines, -5 lines 0 comments Download
M gpu/src/GrGpuGLShaders2.cpp View 10 chunks +36 lines, -36 lines 0 comments Download
M vs/SampleApp/SampleApp.vcxproj View 1 chunk +1 line, -0 lines 0 comments Download
M vs/SampleApp/SampleApp.vcxproj.filters View 1 chunk +3 lines, -0 lines 0 comments Download
M xcode/gpu/gpu.xcodeproj/project.pbxproj View 1 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4
twiz1
Please take a look. Most of the changes are fairly trivial. I pulled in all ...
13 years, 8 months ago (2011-03-18 03:30:58 UTC) #1
bsalomon
Jeff, it LGTM. I think we should omit the changes in SkUIView.h but otherwise this ...
13 years, 8 months ago (2011-03-18 13:25:01 UTC) #2
twiz1
http://codereview.appspot.com/4272061/diff/3001/gpu/include/SkUIView.h File gpu/include/SkUIView.h (right): http://codereview.appspot.com/4272061/diff/3001/gpu/include/SkUIView.h#newcode7 gpu/include/SkUIView.h:7: On 2011/03/18 13:25:01, bsalomon wrote: > I don't think ...
13 years, 8 months ago (2011-03-18 15:15:36 UTC) #3
bsalomon
13 years, 8 months ago (2011-03-18 15:27:41 UTC) #4
LGTM.

On 2011/03/18 15:15:36, twiz1 wrote:
> http://codereview.appspot.com/4272061/diff/3001/gpu/include/SkUIView.h
> File gpu/include/SkUIView.h (right):
> 
>
http://codereview.appspot.com/4272061/diff/3001/gpu/include/SkUIView.h#newcode7
> gpu/include/SkUIView.h:7: 
> On 2011/03/18 13:25:01, bsalomon wrote:
> > I don't think we need to modify this file. It supports the Ganesh/skia iOS
> demo
> > app and its fine for it to be aware of the platform GL types.
> 
> Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b