Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2508)

Issue 4298043: Blender Animation: Jog keys

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by elubie
Modified:
13 years, 1 month ago
Reviewers:
brechtvl aligorith, aligorith, bf-codereview
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

This patch implements a simple version of 'jog keys'. Functionality: Alternative keys for animation playback: ALT + Right Arrow: Start animation playback forward or increase speed if already playing ALT + Left Arrow: Start animation playback backward or increase speed if already playing backwards The speed is currently clamped at 6x normal speed. Implementation Notes: This is a cleaned up version of a previous commit that had issues - if I remember correctly the playback buttons weren't working as expected anymore. I have tested the current patch and it seems ok. The jog keys are disabled if the animation is synched to the sound (AV-sync) and playing forward - in my view it also doesn't make sense to speed up if you synch to the sound. Waiting for feedback :)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Thanks for the review Brecht, new version here. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -37 lines) Patch
source/blender/editors/include/ED_screen.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
source/blender/editors/include/ED_screen_types.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
source/blender/editors/render/render_internal.c View 1 1 chunk +1 line, -1 line 0 comments Download
source/blender/editors/screen/screen_edit.c View 1 2 chunks +3 lines, -2 lines 0 comments Download
source/blender/editors/screen/screen_ops.c View 1 8 chunks +58 lines, -31 lines 0 comments Download
source/blender/windowmanager/intern/wm_event_system.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
elubie
13 years, 2 months ago (2011-03-16 21:35:18 UTC) #1
brechtvl
Thanks for using the system, nice to see it getting used, some comments below. http://codereview.appspot.com/4298043/diff/1/source/blender/editors/screen/screen_ops.c ...
13 years, 2 months ago (2011-03-17 10:43:26 UTC) #2
brechtvl
Also, maybe add Joshua to the reviewers, assuming you discussed this with him last time?
13 years, 2 months ago (2011-03-17 10:48:30 UTC) #3
elubie
Thanks for the review Brecht, new version here.
13 years, 1 month ago (2011-03-19 21:05:52 UTC) #4
aligorith
13 years, 1 month ago (2011-03-20 10:11:46 UTC) #5
Just a quick comment: 
I think we should postpone this, at least until after 2.57 is released, since
the underlying code here is starting to get quite hairy. In particular the long
chains of args that need to be passed in. It's all getting a bit out of control,
so adding this on seems to just make matters worse.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b