Issue 4291075: code review 4291075: asn1: extensions needed for parsing Kerberos

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4291075: code review 4291075: asn1: extensions needed for parsing Kerberos (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by agl1

Modified:
14 years, 1 month ago

Reviewers:

CC:
golang-dev, rsc1, r

Visibility:
Public.

Description

asn1: extensions needed for parsing Kerberos * Adds support for GENERAL STRING * Adds support for APPLICATION tagged values. * Add UnmarshalWithParams to set parameters for the top-level structure

Patch Set 2 : diff -r 242439bc6eee https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 3 : diff -r 8a5182237f9d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8a5182237f9d https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 8a5182237f9d https://go.googlecode.com/hg/ #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -5 lines)			Patch
M	src/pkg/asn1/asn1.go	View	1 2	6 chunks	+32 lines, -2 lines	0 comments	Download
M	src/pkg/asn1/asn1_test.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/asn1/common.go	View	1	4 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

LGTM http://codereview.appspot.com/4291075/diff/2001/src/pkg/asn1/asn1.go File src/pkg/asn1/asn1.go (right): http://codereview.appspot.com/4291075/diff/2001/src/pkg/asn1/asn1.go#newcode725 src/pkg/asn1/asn1.go:725: // which allow the encoding to change midstring ...

14 years, 1 month ago (2011-03-28 21:10:50 UTC) #3

agl1

Hello golang-dev@googlegroups.com, rsc1, r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 1 month ago (2011-03-29 14:32:55 UTC) #4

agl1

14 years, 1 month ago (2011-03-29 14:33:55 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=d76a9f7be92a ***

asn1: extensions needed for parsing Kerberos

* Adds support for GENERAL STRING
* Adds support for APPLICATION tagged values.
* Add UnmarshalWithParams to set parameters for the top-level
  structure

R=golang-dev, rsc1, r
CC=golang-dev
http://codereview.appspot.com/4291075

http://codereview.appspot.com/4291075/diff/2001/src/pkg/asn1/asn1.go
File src/pkg/asn1/asn1.go (right):

http://codereview.appspot.com/4291075/diff/2001/src/pkg/asn1/asn1.go#newcode725
src/pkg/asn1/asn1.go:725: // which allow the encoding to change midstring and
On 2011/03/28 21:10:50, r wrote:
> s/which/that/

Done.

Expand All Messages | Collapse All Messages