Issue 4291064: code review 4291064: chan: allocate a new chan with one

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4291064: code review 4291064: chan: allocate a new chan with one (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by ken2

Modified:
14 years, 1 month ago

Reviewers:
r2

CC:
rsc, r, golang-dev

Visibility:
Public.

chan: allocate a new chan with one malloc rather than nelements + 1.

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -4 lines)			Patch
	M	src/pkg/runtime/chan.c	View	1	4 chunks	+20 lines, -4 lines	0 comments	Download

Total messages: 4

ken2

Hello rob (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 1 month ago (2011-03-23 01:41:15 UTC) #1

ken2

*** Submitted as http://code.google.com/p/go/source/detail?r=7c59a8fa31c3 *** chan: allocate a new chan with one malloc rather than ...

14 years, 1 month ago (2011-03-23 01:41:22 UTC) #2

14 years, 1 month ago (2011-03-23 03:24:38 UTC) #4

you sent that to rob@, who is dr robert nilsson.  i hope he likes it.

LGTM and thanks

-rob