Issue 4290056: code review 4290056: gob: eliminate two more allocations in decode.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4290056: code review 4290056: gob: eliminate two more allocations in decode. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by r

Modified:
14 years, 2 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

gob: eliminate two more allocations in decode. - just an oversight; we were reallocating a buffer. - use unsafe to avoid allocating storage for a string twice.

Patch Set 1 #

Patch Set 2 : diff -r 47d594612053 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d0821ccb1585 https://go.googlecode.com/hg/ #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	src/pkg/gob/decode.go	View	1 2	2 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 2 months ago (2011-03-17 16:41:26 UTC) #1

rsc

LGTM Actually it depends on the memory representation of a string matching the beginning of ...

14 years, 2 months ago (2011-03-17 17:24:05 UTC) #2

14 years, 2 months ago (2011-03-17 17:47:45 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=a255bee7b78b ***

gob: eliminate two more allocations in decode.
- just an oversight; we were reallocating a buffer.
- use unsafe to avoid allocating storage for a string twice.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4290056

Expand All Messages | Collapse All Messages