Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(499)

Issue 4289077: code review 4289077: runtime: Fix gdb support for goroutines. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by lvd
Modified:
14 years, 1 month ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

runtime: fix gdb support for goroutines. in gdb, 'info goroutines' and 'goroutine <n> <cmd> were crashing because the 'g' and 'm' structures had changed a bit.

Patch Set 1 #

Patch Set 2 : diff -r b5c246d30318 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b5c246d30318 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 3807b738e9ff https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M src/pkg/runtime/runtime-gdb.py View 1 3 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 4
lvd
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 1 month ago (2011-03-28 12:29:10 UTC) #1
rsc
LGTM Please expand the CL description (hg change) to say what the old behavior was ...
14 years, 1 month ago (2011-03-28 14:14:17 UTC) #2
lvd
done and submitted. On Mon, Mar 28, 2011 at 16:14, Russ Cox <rsc@golang.org> wrote: > ...
14 years, 1 month ago (2011-03-28 15:33:56 UTC) #3
lvd
14 years, 1 month ago (2011-03-28 15:34:29 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=a2cc9baea5d3 ***

runtime: fix gdb support for goroutines.

in gdb, 'info goroutines' and 'goroutine <n> <cmd> were crashing
because the 'g' and 'm' structures had changed a bit.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4289077
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b