Issue 4287048: Use cmake install target on Mac

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4287048: Use cmake install target on Mac (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by brechtvl

Modified:
13 years, 2 months ago

Reviewers:
kent.mein, bf-codereview

Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/

Visibility:
Public.

Description

Other platforms are already using it, this brings Mac in line. Will commit in 24 hours if no comments come up.

Patch Set 1 #

Total comments: 1

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -36 lines)			Patch
		GNUmakefile	View		2 chunks	+1 line, -4 lines	1 comment	Download
		source/creator/CMakeLists.txt	View		1 chunk	+92 lines, -32 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

sirdude

On 2011/03/15 12:08:41, brechtvl wrote: I haven't had a chance to download it and try ...

13 years, 2 months ago (2011-03-15 14:19:52 UTC) #2

sirdude

http://codereview.appspot.com/4287048/diff/1/GNUmakefile File GNUmakefile (left): http://codereview.appspot.com/4287048/diff/1/GNUmakefile#oldcode51 GNUmakefile:51: DEFAULT_TARGET=install Makes sense to clean this up not needed ...

13 years, 2 months ago (2011-03-15 14:32:45 UTC) #3

Committed.

Expand All Messages | Collapse All Messages