Changes spanner-placement to a ly:dir.

Changes spanner-placement to a ly:dir.

This changes makes it such that a footnote annotation can only ever
fall on the first or last spanner.

[hanwenn, 2011-03-12 14:17:12]

http://codereview.appspot.com/4286042/diff/2001/lily/balloon.cc
File lily/balloon.cc (right):

http://codereview.appspot.com/4286042/diff/2001/lily/balloon.cc#newcode77
lily/balloon.cc:77: return SCM_EOL;
not sure I follow.  Why not

  if (!me->spanned_rank().contains(pos)) return 

?

also, you couldl just look at me->break_index_ to see if you're on the right
piece?

wanted = (d ==LEFT) ? parent->broken_.begin() : parent->broken_.end()-1;
if (me!=wanted) return

http://codereview.appspot.com/4286042/diff/2001/lily/system.cc
File lily/system.cc (right):

http://codereview.appspot.com/4286042/diff/2001/lily/system.cc#newcode272
lily/system.cc:272: if (pos < (int)start)
new style casts.

[hanwenn, 2011-03-12 14:17:31]

for the rest lgtm.

[hanwenn, 2011-03-12 14:20:18]

[+lilydevel]

On Sat, Mar 12, 2011 at 11:17 AM,  <hanwenn@gmail.com> wrote:
>
> http://codereview.appspot.com/4286042/diff/2001/lily/balloon.cc
> File lily/balloon.cc (right):
>
> http://codereview.appspot.com/4286042/diff/2001/lily/balloon.cc#newcode77
> lily/balloon.cc:77: return SCM_EOL;
> not sure I follow.  Why not
>
>  if (!me->spanned_rank().contains(pos)) return
>
> ?
>
> also, you couldl just look at me->break_index_ to see if you're on the
> right piece?
>
> wanted = (d ==LEFT) ? parent->broken_.begin() : parent->broken_.end()-1;
> if (me!=wanted) return
>
> http://codereview.appspot.com/4286042/diff/2001/lily/system.cc
> File lily/system.cc (right):
>
> http://codereview.appspot.com/4286042/diff/2001/lily/system.cc#newcode272
> lily/system.cc:272: if (pos < (int)start)
> new style casts.
>
> http://codereview.appspot.com/4286042/
>



-- 
Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen

[mike_apollinemike.com, 2011-03-13 21:15:19]

On Mar 12, 2011, at 9:17 AM, hanwenn@gmail.com wrote:

> 
> http://codereview.appspot.com/4286042/diff/2001/lily/balloon.cc
> File lily/balloon.cc (right):
> 
> http://codereview.appspot.com/4286042/diff/2001/lily/balloon.cc#newcode77
> lily/balloon.cc:77: return SCM_EOL;
> not sure I follow.  Why not
> 
> if (!me->spanned_rank().contains(pos)) return
> 
> ?
> 
> also, you couldl just look at me->break_index_ to see if you're on the
> right piece?
> 
> wanted = (d ==LEFT) ? parent->broken_.begin() : parent->broken_.end()-1;
> if (me!=wanted) return
> 
> http://codereview.appspot.com/4286042/diff/2001/lily/system.cc
> File lily/system.cc (right):
> 
> http://codereview.appspot.com/4286042/diff/2001/lily/system.cc#newcode272
> lily/system.cc:272: if (pos < (int)start)
> new style casts.
> 

All issues addressed.  New patch set up at
http://codereview.appspot.com/4286042/

Cheers,
MS