Issue 4282052: code review 4282052: codereview: permit CLs of the form weekly.DATE

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4282052: code review 4282052: codereview: permit CLs of the form weekly.DATE (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by adg

Modified:
14 years, 2 months ago

Reviewers:

CC:
rsc, r, golang-dev

Visibility:
Public.

Description

codereview: permit CLs of the form weekly.DATE gobuilder: recognize CLs of the form weekly.DATE

Patch Set 1 #

Total comments: 1

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	lib/codereview/codereview.py	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	misc/dashboard/builder/main.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 2 months ago (2011-03-16 05:18:41 UTC) #1

http://codereview.appspot.com/4282052/diff/1/lib/codereview/codereview.py File lib/codereview/codereview.py (right): http://codereview.appspot.com/4282052/diff/1/lib/codereview/codereview.py#newcode782 lib/codereview/codereview.py:782: desc_re = '^(.+: |tag (release|weekly)\.|(release|weekly)\.|fix build)' this is ok ...

14 years, 2 months ago (2011-03-16 05:27:26 UTC) #2

adg

14 years, 2 months ago (2011-03-16 22:11:10 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=7ec9cb1c9303 ***

codereview: permit CLs of the form weekly.DATE
gobuilder: recognize CLs of the form weekly.DATE

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/4282052

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages