code review 4281069: build: fix version.bash

build: fix version.bash

This CL properly prepends the hg tag to the
version string.

[dave_cheney.net, 2011-03-25 12:53:57]

Hello adg (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-03-25 16:13:42]

prepend does not mean what you think it means.
also, what version of awk are you using that can't parse its command
line properly?  :-)

$ awk -vver=x 'BEGIN{print ver}'
x
$

[ality, 2011-03-25 20:50:26]

Russ Cox <rsc@golang.org> once said:
> prepend does not mean what you think it means.
> also, what version of awk are you using that can't parse its command
> line properly?  :-)

This would've failed if he was running the awk from
Plan 9 or p9p, or an old version of the one true awk.

$ gawk -vver=x 'BEGIN{print ver}'
x
$ mawk -vver=x 'BEGIN{print ver}'
x
$ nawk -vver=x 'BEGIN{print ver}'
x
$ 9 awk -vver=x 'BEGIN{print ver}'

$

bwk fixed this bug on May 23, 2010.

I wrote an awk script (which itself runs an ed script)
that munges the awk source and makes all the necessary
changes for Plan 9's awk.  I'll clean it up and send a
patch this weekend.

  Anthony

[rsc, 2011-03-25 21:59:05]

LGTM

[rsc, 2011-03-25 22:00:24]

*** Submitted as http://code.google.com/p/go/source/detail?r=f75a02fd83be ***

build: handle broken awk in version.bash

R=adg, rsc, ality
CC=golang-dev
http://codereview.appspot.com/4281069

Committer: Russ Cox <rsc@golang.org>

[dave_cheney.net, 2011-03-26 00:15:38]

This was on Darwin 10.6.7. I have the Xcode 4 buildchain installed. 


Sent from my C64

On 26/03/2011, at 3:13, Russ Cox <rsc@golang.org> wrote:

> prepend does not mean what you think it means.
> also, what version of awk are you using that can't parse its command
> line properly?  :-)
> 
> $ awk -vver=x 'BEGIN{print ver}'
> x
> $