Issue 4277089: code review 4277089: scanner: treat line comments like in Go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4277089: code review 4277089: scanner: treat line comments like in Go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by gri

Modified:
14 years, 1 month ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

scanner: treat line comments like in Go - don't consume '\n' as part of line comment (otherwise grammars where '\n' are tokens won't see them after a line comment) - permit line comments to end in EOF

Patch Set 1 #

Patch Set 2 : diff -r 7247c0730fbf https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7247c0730fbf https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 7247c0730fbf https://go.googlecode.com/hg/ #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -48 lines)			Patch
	M	src/pkg/scanner/scanner.go	View	1	3 chunks	+16 lines, -27 lines	0 comments	Download
	M	src/pkg/scanner/scanner_test.go	View	1 2 3	19 chunks	+45 lines, -21 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 1 month ago (2011-03-30 21:37:11 UTC) #1

LGTM http://codereview.appspot.com/4277089/diff/5001/src/pkg/scanner/scanner_test.go File src/pkg/scanner/scanner_test.go (right): http://codereview.appspot.com/4277089/diff/5001/src/pkg/scanner/scanner_test.go#newcode511 src/pkg/scanner/scanner_test.go:511: // make sure there were no token-internal errors ...

14 years, 1 month ago (2011-03-30 22:11:25 UTC) #2

gri

14 years, 1 month ago (2011-03-30 22:26:59 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=d4a8eff854f6 ***

scanner: treat line comments like in Go

- don't consume '\n' as part of line comment
(otherwise grammars where '\n' are tokens won't
see them after a line comment)

- permit line comments to end in EOF

R=r
CC=golang-dev
http://codereview.appspot.com/4277089

Expand All Messages | Collapse All Messages