code review 4277075: crypto/x509: Parse Extended Key Usage extension

crypto/x509: Parse Extended Key Usage extension

This changeset makes it possible for crypto/x509 to parse
certificates that include the 'Extended Key Usage' extension
with the critical bit set.

[mkrautz, 2011-03-27 23:29:00]

Hello agl1 (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[agl1, 2011-03-28 13:46:49]

LGTM with suggested change.

http://codereview.appspot.com/4277075/diff/6001/src/pkg/crypto/x509/x509.go
File src/pkg/crypto/x509/x509.go (right):

http://codereview.appspot.com/4277075/diff/6001/src/pkg/crypto/x509/x509.go#n...
src/pkg/crypto/x509/x509.go:724: if u.Equal(oidExtKeyUsageAny) {
This should be
switch {
case u.Equal(oid...):
  ...
case ...
...
}

[mkrautz, 2011-03-28 22:20:44]

Hello agl1 (cc: golang-dev@googlegroups.com),

Please take another look.

[agl1, 2011-03-29 14:35:42]

*** Submitted as http://code.google.com/p/go/source/detail?r=4bbad5626740 ***

crypto/x509: Parse Extended Key Usage extension

This changeset makes it possible for crypto/x509 to parse
certificates that include the 'Extended Key Usage' extension
with the critical bit set.

R=agl1
CC=golang-dev
http://codereview.appspot.com/4277075

Committer: Adam Langley <agl@golang.org>