Issue 4275060: code review 4275060: syscall: rename from .sh to .pl, because these files ar...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4275060: code review 4275060: syscall: rename from .sh to .pl, because these files ar... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by r

Modified:
14 years, 9 months ago

Reviewers:

CC:
rsc, r2, golang-dev

Visibility:
Public.

Description

syscall: rename from .sh to .pl, because these files are in Perl. Also delete references to nacl.

Patch Set 1 #

Patch Set 2 : diff -r 5579de957a47 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5579de957a47 https://go.googlecode.com/hg/ #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -33 lines)			Patch
M	src/pkg/syscall/mkall.sh	View	1	3 chunks	+14 lines, -23 lines	0 comments	Download
M	src/pkg/syscall/mksyscall.pl	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/syscall/mksyscall_windows.pl	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/syscall/mksysnum_darwin.pl	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/mksysnum_freebsd.pl	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/mksysnum_linux.pl	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/zsyscall_darwin_amd64.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/zsysnum_darwin_amd64.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/ztypes_darwin_amd64.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 9 months ago (2011-03-21 19:33:52 UTC) #1

Hello rsc, r2 (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 9 months ago (2011-03-21 19:46:21 UTC) #3

14 years, 9 months ago (2011-03-21 20:02:17 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=e9691d99ab75 ***

syscall: rename from .sh to .pl, because these files are in Perl.
Also delete references to nacl.

R=rsc, r2
CC=golang-dev
http://codereview.appspot.com/4275060

Expand All Messages | Collapse All Messages